Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle pointee_align #606

Open
antoyo opened this issue Jan 23, 2025 · 2 comments · May be fixed by #621
Open

Handle pointee_align #606

antoyo opened this issue Jan 23, 2025 · 2 comments · May be fixed by #621
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@antoyo
Copy link
Contributor

antoyo commented Jan 23, 2025 •
edited
Loading

I noticed we don't handle pointee_align.

To implement this, look for pointee_align in cg_llvm and implement the same logic in cg_gcc.
@antoyo antoyo added enhancement New feature or request good first issue Good for newcomers labels Jan 23, 2025
@g4titanx
Copy link
Contributor

g4titanx commented Feb 6, 2025

hey @antoyo can you provide more context on this and i'd like to get on it as soon as possible
also, i'm yet to get a review on this pr: #586

@antoyo
Copy link
Contributor Author

antoyo commented Feb 6, 2025

I added a bit more context in the top comment. Feel free to ask questions if you need more help.

I've been very busy these past weeks: I should be able to look at this PR by next week if it goes well.

@g4titanx g4titanx linked a pull request Feb 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle pointee_align g4titanx/rustc_codegen_gcc
2 participants
@antoyo @g4titanx