Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark arm intrinsics as safe #1716

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

usamoi
Copy link
Contributor

@usamoi usamoi commented Feb 15, 2025

This patch marks all neon intrinsics that do not operate on memory, crc and crypto intrinsics as safe.

ACP: rust-lang/libs-team#494

@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2025

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@usamoi usamoi force-pushed the target_feature_11_updates_arm branch from 869b73d to e84377a Compare February 16, 2025 08:48
@Amanieu
Copy link
Member

Amanieu commented Feb 23, 2025

ARM maintainers should have a second pass at reviewing this.

cc @JamieCunliffe @adamgemmell @Jamesbarford

@Jamesbarford
Copy link
Contributor

It might be beneficial to have #1708 merged prior to these changes as #1708 converts most of the manually defined intrinsics to the YAML file.

@usamoi usamoi force-pushed the target_feature_11_updates_arm branch from e84377a to 7cad4ce Compare February 24, 2025 15:52
@Amanieu
Copy link
Member

Amanieu commented Feb 24, 2025

This needs another rebase since the f16 intrinsics were added.

@usamoi usamoi force-pushed the target_feature_11_updates_arm branch 2 times, most recently from 9c975ba to 8a959c6 Compare February 25, 2025 11:26
@usamoi usamoi force-pushed the target_feature_11_updates_arm branch from 8a959c6 to 216ce54 Compare February 26, 2025 11:11
@Jamesbarford
Copy link
Contributor

LGTM

@Amanieu Amanieu added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 26, 2025
@usamoi usamoi force-pushed the target_feature_11_updates_arm branch from 216ce54 to 742cbfe Compare February 26, 2025 13:27
@Amanieu Amanieu added this pull request to the merge queue Feb 27, 2025
Merged via the queue into rust-lang:master with commit 52fd0e1 Feb 27, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants