Skip to content

pingora request smuggling and cache poisoning #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 22, 2025

Conversation

Noah-Kennedy
Copy link
Contributor

Pingora has a request smuggling and cache poisoning vulnerability affecting versions 0.5.0 and older, as documented here: https://blog.cloudflare.com/resolving-a-request-smuggling-vulnerability-in-pingora/

Pingora has a request smuggling and cache poisoning vulnerability
affecting versions 0.5.0 and older, as documented here:
https://blog.cloudflare.com/resolving-a-request-smuggling-vulnerability-in-pingora/
@Noah-Kennedy
Copy link
Contributor Author

None of the categories appear to quite fit this vuln.

Could I get some input from a maintainer on if leaving that blank is the correct move, or if one of the categories might encompass this vulnerability?

@djc
Copy link
Contributor

djc commented May 22, 2025

I think privilege escalation comes closest probably? This does allow an attacker to do things that they normally should not be able to do?

@djc
Copy link
Contributor

djc commented May 22, 2025

Also probably good to clean out the comments and give it a correct CVSS?

@Noah-Kennedy
Copy link
Contributor Author

Also probably good to clean out the comments and give it a correct CVSS?

I can't really calculate a useful score here. It's very dependent on how you are using the framework and what you are doing. Though I suppose this criticism of CVSS scores can be made it 90% of cases.

I can clean out the comments though!

@Noah-Kennedy
Copy link
Contributor Author

I think privilege escalation comes closest probably? This does allow an attacker to do things that they normally should not be able to do?

Maybe? I can construct scenarios where this could be used to bypass ACLs I suppose.

@Noah-Kennedy
Copy link
Contributor Author

But also, the wording of "privilege escalation" seems too focused for what you can do here.

@Noah-Kennedy
Copy link
Contributor Author

And actually, I'm not sure now that I think about it that you could really use this to bypass ACLs on any realistic configuration.

@Noah-Kennedy
Copy link
Contributor Author

Actually, since there is a CVE now I will link that and use the existing score.

@Noah-Kennedy
Copy link
Contributor Author

Noah-Kennedy commented May 22, 2025

Nevermind, I don't know if that one is finalized, leaving commented for now

@Noah-Kennedy
Copy link
Contributor Author

@djc I've added the CVE now that it's live and also added the CVSS

@Noah-Kennedy
Copy link
Contributor Author

@djc I only have a CVSS 4.0, which is unsupported.

I'm going to drop it as it's in the linked CVE.

@Noah-Kennedy
Copy link
Contributor Author

I'm good with merging this now.

@Shnatsel Shnatsel merged commit ed30d21 into rustsec:main May 22, 2025
1 check passed
@Noah-Kennedy Noah-Kennedy deleted the noah/pingora-smuggling branch May 22, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants