Skip to content

Rocket should show 405 instead of 404 for method not allowed #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
silvioprog opened this issue Feb 8, 2020 · 6 comments · May be fixed by #2616
Open

Rocket should show 405 instead of 404 for method not allowed #1224

silvioprog opened this issue Feb 8, 2020 · 6 comments · May be fixed by #2616
Labels
request Request for new functionality
Milestone
0.6.0

Comments

@silvioprog
Copy link

Hi.

Consider the following route:

#[post("/hello")]
pub fn hello() -> &'static str {
    "Hello"
}

now, if you call it with:

curl http://localhost:8000/hello

it returns:

<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8" />
    <title>404 Not Found</title>
  </head>
  <body align="center">
    <div align="center">
      <h1>404: Not Found</h1>
      <p>The requested resource could not be found.</p>
      <hr />
      <small>Rocket</small>
    </div>
  </body>
</html>

however, since the passed URL is correct and only the method (verb) is wrong, according to rfc7231#section-6.5.5, it should return 405: Method Not Allowed with an Allow header field in a 405 response containing a list of the target resource's currently supported methods.

So, if you don't agree with that, could you provide a global option to send 405 instead of 404 for handling method not allowed errors?

TIA
@jebrosen jebrosen added the request Request for new functionality label Feb 8, 2020
@jebrosen
Copy link
Collaborator

From https://tools.ietf.org/html/rfc7231#section-4.1:

When a request method is received that is known by an origin
server but not allowed for the target resource, the origin server
SHOULD respond with the 405 (Method Not Allowed) status code.

I sounds like a good idea to default to 405 instead of 404, then - and applications that want a 404 can add a 405 catcher that returns a 404.

@Drunpy Drunpy mentioned this issue Apr 14, 2020
Closed
@Drunpy Drunpy mentioned this issue Aug 7, 2020
Closed
@peng1999 peng1999 mentioned this issue Dec 30, 2020
Closed
jespersm added a commit to jespersm/Rocket that referenced this issue Sep 20, 2023
@jespersm
Fix rwf2#1224 by searching routes after failed match
7251c5b
@jespersm jespersm linked a pull request Sep 20, 2023 that will close this issue
Open
@SergioBenitez SergioBenitez added this to the 0.6.0 milestone Nov 1, 2023
@SergioBenitez SergioBenitez moved this to Backlog in Rocket v0.6 Dec 12, 2023
@bharathk005
Copy link

@SergioBenitez does #2616 fix this or do we still need a solution?

jespersm added a commit to jespersm/Rocket that referenced this issue Sep 5, 2024
@jespersm
Fix rwf2#1224 by searching routes after failed match
be52278
@rubbieKelvin
Copy link

rubbieKelvin commented Mar 23, 2025 •
edited
Loading

why's this still open? it's been 5 years 😢

@igmrrf
Copy link

igmrrf commented Apr 10, 2025

why's this still open? it's been 5 years 😢

Sadly the PR is still open.

@reneleonhardt
Copy link

reneleonhardt commented Apr 10, 2025 •
edited
Loading

why's this still open? it's been 5 years 😢

Sadly the PR is still open.

Sadly Rocket saw no release for a year... @silvioprog could you checkout, build and test #2616? 😅
I tried it locally and received 405 from a POST endpoint, when I switched back to master I received 404.

@jespersm who can review and merge your branch, is it ready? 🙂

@reneleonhardt
Copy link

@SergioBenitez could you review #2616?
When will Rocket be ready for a new release? 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
request Request for new functionality
Projects
Rocket v0.6
Status: Backlog
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Fix #1224 by searching routes after failed match jespersm/Rocket
Implement HTTP 405
7 participants
@silvioprog @SergioBenitez @jebrosen @bharathk005 @rubbieKelvin @igmrrf @reneleonhardt