New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider breaking up your controller file into classes a bit more #12

Open

danmarsden opened this issue Aug 13, 2022 · 1 comment

danmarsden commented Aug 13, 2022

one example of how this could be done is the way mod_assign view() class handles actions:
https://github.com/moodle/moodle/blob/master/mod/assign/locallib.php#L511-L541

not a blocker for approval - feel free to close as won't fix - it's just that controller file is starting to look a bit messy.

Collaborator

Amrita1991 commented Aug 16, 2022

I actually am aware about it. I intend to fix it but yea nopt immediately..maybe with a new version in the future so I am keeping it open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment