Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Moodle 4.1] Several uses of deprecated print_error() function #129

Open
danowar2k opened this issue Jan 8, 2025 · 2 comments
Open

[Moodle 4.1] Several uses of deprecated print_error() function #129

danowar2k opened this issue Jan 8, 2025 · 2 comments

Comments

@danowar2k
Copy link

Moodle Version in use
Moodle 4.1.13

** Plugin Version **
PDF Annotator v1.5 release 4 (but irrelevant, code is still present in master)

Describe the bug
Moodle's print_error() function is deprecated since Moodle 4.1, see https://tracker.moodle.org/browse/MDL-71062 (and is removed in Moodle 4.5)

There are several spots in the code that still use this function: https://github.com/search?q=repo%3Arwthmoodle%2Fmoodle-mod_pdfannotator%20print_error(&type=code

They should be replaced with throwing exceptions.

@sharpchi
Copy link

This patch should resolve this issue

P0026-mod_pdfannotator_deprecated_print_error.txt

@Amrita1991
Copy link
Contributor

Thanks @sharpchi we will be incorporating this in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants