Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] [1.5.7] get_all_user_name_fields() deprecated since Moodle 3.11 #132

Open
danowar2k opened this issue Jan 21, 2025 · 1 comment
Open

Comments

@danowar2k
Copy link

Moodle Version in use
Moodle 4.4.5

** Plugin Version **
1.5.7

Describe the bug
get_all_user_name_fields() is deprecated since Moodle 3.11 and was removed in Moodle 4.3, see https://tracker.moodle.org/browse/MDL-70187.
Please replace the code with something like this:

if (class_exists('\core_user\fields')) {
   $allnames = \core_user\fields::for_name()->get_sql('u', true);
} else {
    $allnames = get_all_user_name_fields(true, 'u');
}

I just found that in the plugin code while searching for places where the function is used. I don't have any steps to reproduce the "bug". As the Code is in pdfannotator_get_recent_mod_activity() it may well come up when using block_recent_activity, for example. Or the activity reports...

@Amrita1991
Copy link
Contributor

Thank you for reporting this. We noticed that the function to print recent activities of pdfannotator is not correctly implemented. Hence we never noticed this error. We have taken this in our Backlog and will soon be bringing in the enhancement. Thank you for your patience and we are sorry to cause any inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants