Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: create a folder with experimental contracts, add a deploy script for WebAuthnSignerFactory #202

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Feature: create a folder with experimental contracts, add a deploy script for WebAuthnSignerFactory #202

merged 1 commit into from
Jan 12, 2024

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jan 12, 2024 •
edited
Loading

As discussed in Slack, we agreed that moving experimental contracts (mainly related to passkeys) outside of the test folder made sense.

This PR:

  • Moves passkeys-related contracts to the experimental folder
  • Adds a deployment script for WebauthnSignerFactory
  • Adds Copilot-generated docs to the WebAuthnSigner contract
  • Move FCL to the vendor folder

@mmv08 mmv08 requested a review from a team as a code owner January 12, 2024 10:46
@mmv08 mmv08 requested review from rmeissner, nlordell, akshay-ap and remedcu and removed request for a team January 12, 2024 10:46
@mmv08 mmv08 marked this pull request as draft January 12, 2024 10:47
@mmv08 mmv08 force-pushed the feat/migrate-and-deploy-webauthn-signer branch from e40bf11 to fa67ade Compare January 12, 2024 11:13
@coveralls
Copy link

coveralls commented Jan 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7503694399

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-63.4%) to 36.646%
Totals Coverage Status
Change from base Build 7500989453: -63.4%
Covered Lines: 36
Relevant Lines: 107
💛 - Coveralls

@mmv08 mmv08 marked this pull request as ready for review January 12, 2024 11:15
@mmv08 mmv08 force-pushed the feat/migrate-and-deploy-webauthn-signer branch 2 times, most recently from 72e017d to fed5576 Compare January 12, 2024 13:19
nlordell
nlordell reviewed Jan 12, 2024
View reviewed changes
4337/contracts/experimental/WebAuthnSigner.sol Outdated
@@ -1,8 +1,9 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newline?

nlordell
nlordell reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@nlordell nlordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you make sure to add vendor and experiments to the coverage exceptions?

@mmv08 mmv08 force-pushed the feat/migrate-and-deploy-webauthn-signer branch 2 times, most recently from 463e313 to 851dd0a Compare January 12, 2024 14:07
@mmv08
Copy link
Member Author

mmv08 commented Jan 12, 2024

Nice! Can you make sure to add vendor and experiments to the coverage exceptions?

Have added it to solcover ignore

@mmv08 mmv08 requested a review from nlordell January 12, 2024 14:13
nlordell
nlordell reviewed Jan 12, 2024
View reviewed changes
4337/.solhintignore Outdated
@@ -1 +1,2 @@
contracts/test/FCL/
contracts/vendor/FCL/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra newline.

@mmv08 mmv08 force-pushed the feat/migrate-and-deploy-webauthn-signer branch from 851dd0a to 3f4005a Compare January 12, 2024 14:48
@mmv08 mmv08 merged commit 7b047e0 into master Jan 12, 2024
8 checks passed
@mmv08 mmv08 deleted the feat/migrate-and-deploy-webauthn-signer branch January 12, 2024 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nlordell nlordell nlordell approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner was automatically assigned from safe-global/safe-protocol

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap was automatically assigned from safe-global/safe-protocol

@remedcu remedcu Awaiting requested review from remedcu remedcu was automatically assigned from safe-global/safe-protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmv08 @coveralls @nlordell