Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an updated EIP-1271 function to the WebAuthn signer #205

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jan 15, 2024

This PR:

  • Adds an updated EIP-1271 validation method to the WebAuthnSigner contract for futureproofing
  • I created an abstract contract with both magic values, similar to how it's done in the Safe Account contract. We cannot reuse the Safe's contract because it only includes one value (either the legacy or the new one)
  • I had to adjust the return values of signature-validating functions slightly. For the generic checkSignatures function, I changed it to a boolean, similar to how it's done in the underlying FCL's validation function

@mmv08 mmv08 requested a review from a team as a code owner January 15, 2024 12:09
@mmv08 mmv08 requested review from rmeissner, nlordell, akshay-ap and remedcu and removed request for a team January 15, 2024 12:09
@mmv08 mmv08 force-pushed the feat/eip1271-version-update branch from ee981ec to e7e9d0d Compare January 15, 2024 12:10
@coveralls
Copy link

coveralls commented Jan 15, 2024

Pull Request Test Coverage Report for Build 7530149666

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.4%) to 82.738%

Totals Coverage Status
Change from base Build 7504336477: -2.4%
Covered Lines: 101
Relevant Lines: 110

💛 - Coveralls

@mmv08 mmv08 force-pushed the feat/eip1271-version-update branch 2 times, most recently from 374a876 to 8206e85 Compare January 15, 2024 13:16
@mmv08 mmv08 force-pushed the feat/eip1271-version-update branch from 8206e85 to bb923ca Compare January 15, 2024 14:19
@mmv08 mmv08 merged commit 3853f34 into main Jan 15, 2024
9 checks passed
@mmv08 mmv08 deleted the feat/eip1271-version-update branch January 15, 2024 14:22
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants