Feature/squash npm workspaces feature commits #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ths in README.md, update github workflows, remove modules: recurring_transfers and dutchx_seller [#146] Update root package.json and package-lock.json, delete .eslintrc.cjs in modules/4337-gas-metering
A huge part of the way to #173 This PR adds an E2E test using the reference 4337 EntryPoint and bundler for a Safe deployment with a WebAuthn (i.e. Passkeys) signer. Note that this E2E test is not 100% complete. In particular, we don't get test using the Safe after the launchpad deployment is completed. I want to add that test in a follow-up when I actually add the gas profiling for the WebAuthn signer.
I noticed that the `fallback` function implementation was not memory safe for the SafeMock contract. This PR rectifies this. Additionally, FCL assembly is also not tagged as memory safe (but should be AFAIU). We should probably submit a PR upstream to tag assembly as memory safe.
[#146] Update README.md
Fixes #173 This PR adds tests that execute user operations on Safes with WebAuthn signers over the reference entrypoint and prints out the gas usage. It includes both Safe deployment as well as regular user operation usage. The results are in: ``` Safe4337Module - WebAuthn Owner executeUserOp - new account Used 2293926 gas for >WebAuthn signer Safe deployment< ✔ should execute user operation (357ms) executeUserOp - existing account Used 374142 gas for >WebAuthn signer Safe operation< ✔ should execute user operation (229ms) ```
…ript for `WebAuthnSignerFactory` (#202) As discussed in Slack, we agreed that moving experimental contracts (mainly related to passkeys) outside of the test folder made sense. This PR: - Moves passkeys-related contracts to the experimental folder - Adds a deployment script for `WebauthnSignerFactory` - Adds Copilot-generated docs to the `WebAuthnSigner` contract - Move FCL to the `vendor` folder
|
Did we decide to drop this PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR squashes small intermediate commits related to #146