Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade all dependecies across the board #342

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Upgrade all dependecies across the board #342

merged 4 commits into from
Mar 27, 2024

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Mar 27, 2024 •
edited
Loading

This PR:

  • Updates all dependencies across the board
  • Improves the walletClient type in the nativeTransfer.ts in the benchmarking package. The upgraded viem package had some hardcoded type values (like explorer URL) and the typescript's inferred type couldn't find a union between them

@mmv08 mmv08 requested a review from a team as a code owner March 27, 2024 13:58
@mmv08 mmv08 requested review from nlordell, akshay-ap and remedcu and removed request for a team March 27, 2024 13:58
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8452978045

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+18.5%) to 100.0%
Totals Coverage Status
Change from base Build 8393417595: 18.5%
Covered Lines: 39
Relevant Lines: 39
💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8454675631

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.633%
Totals Coverage Status
Change from base Build 8454662939: 0.0%
Covered Lines: 95
Relevant Lines: 103
💛 - Coveralls

@mmv08 mmv08 merged commit 78ae3b8 into main Mar 27, 2024
12 checks passed
@mmv08 mmv08 deleted the dependencies/upgrade branch March 27, 2024 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nlordell nlordell nlordell approved these changes

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap is a code owner automatically assigned from safe-global/safe-protocol

@remedcu remedcu Awaiting requested review from remedcu remedcu is a code owner automatically assigned from safe-global/safe-protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmv08 @coveralls @nlordell