Skip to content

[Signing UX v2] Epic #5416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
katspaugh opened this issue Mar 20, 2025 · 4 comments · Fixed by #5559
Open

[Signing UX v2] Epic #5416

katspaugh opened this issue Mar 20, 2025 · 4 comments · Fixed by #5559

Comments

@katspaugh
Copy link
Member

A parent ticket for the next iteration of Signing UX improvements. See v1.

Links

Designs
Epic on Notion

@mike10ca
Copy link
Contributor

mike10ca commented Apr 1, 2025

Please do not merge to dev until we run automated regression tests. @francovenica @liliya-soroka fyi

@katspaugh
Copy link
Member Author

@liliya-soroka @francovenica it's merged into dev and can be tested on there.

@katspaugh katspaugh reopened this Apr 16, 2025
@francovenica
Copy link
Contributor

francovenica commented Apr 22, 2025

I think the single action of clicking signing and the action being already triggered in the review step instead of the receipt step fells kinda confusing. In MM is ok cuz the popup shows up fine, but for native ledger you gotta see that the device is asking for the signing, you reach to that point of "What I do now?" until you realize
Also for GNO network you sitill see the "Sponsored" selector that you can still click. I think this is the only network (beyond Sepolia) where this shows up, but I think that if we are going to leave this flow, we should remove that block

@katspaugh
Copy link
Member Author

katspaugh commented Apr 22, 2025

@francovenica good point, we reverted that behavior. So the Sign button will be only on the last screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants