Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bracket highlight for atom, esp on the same line #15

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

emilong
Copy link

@emilong emilong commented May 25, 2016

Hi!

I was having trouble seeing matching brackets, especially on the same line, so I thought I'd try to highlight them. I just picked a high-visibility color in the theme and am happy to change that choice, but the hard part here (for me) was figuring out the way atom does its layering in these cases. It puts the highlight below the current cursor line, so I popped it up with the z-index, but you can't see the underlying character without setting an alpha.

Current:
before

With this change:
after with match

Even if this doesn't go in, I'd love to see some bracket matching in the theme. 😄

Thanks!

@Vectornaut
Copy link

Here's another possibility for the highlight style, which I chose while porting the theme to GtkSourceView. It colors the matched bracket strawberry (#FF857F).
strawberry match
It works okay even in languages where brackets are colored pink.
strawberry match on pink
I don't think brackets are likely to be colored strawberry. They'd have to be classified as function argument for that to happen.

For me, only coloring the text gives a good balance between visibility and distraction. The highlighting stands out more when the cursor is in motion, because the color change calls attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants