Fix IllegalStateException when starting NotificationRemovalService

We where not able to reproduce the issue which was reported by the client. However, theoretically Lifecycle.Event.ON_STOP might be called when app is in bacground causing the error 'IllegalStateException: Not allowed to start service app is in background' but in case of Lifecycle.Event.ON_PAUSE app can't be in the background state.

MOB-4011

Author: gugalo

widgetssdk/src/main/java/com/glia/widgets/core/notification/device/NotificationManager.kt

@@ -10,6 +10,8 @@ import com.glia.widgets.R
 import com.glia.widgets.core.notification.NotificationFactory
 import com.glia.widgets.core.notification.NotificationRemovalService
 import com.glia.widgets.core.notification.areNotificationsEnabledForChannel
+import com.glia.widgets.helper.Logger
+import com.glia.widgets.helper.TAG
 
 internal class NotificationManager(private val applicationContext: Application) : INotificationManager {
     private val notificationManager: NotificationManager by lazy {
@@ -88,7 +90,12 @@ internal class NotificationManager(private val applicationContext: Application)
     override fun startNotificationRemovalService() {
         // If this service is not already running, it will be instantiated and started (creating a process for it if needed);
         // if it is running then it remains running.
-        applicationContext.startService(Intent(applicationContext, NotificationRemovalService::class.java))
+        try {
+            applicationContext.startService(Intent(applicationContext, NotificationRemovalService::class.java))
+        } catch (error: Throwable) {
+            // Above code is known to throw an error if app is in background
+            Logger.e(TAG, "Failed to launch 'NotificationRemovalService'", error)
+        }
     }
 
     override fun removeCallNotification() {

widgetssdk/src/main/java/com/glia/widgets/di/Dependencies.kt

@@ -252,13 +252,17 @@ internal object Dependencies {
         chatBubbleController: ChatHeadContract.Controller
     ) {
         lifecycleManager.addObserver { _, event: Lifecycle.Event ->
-            if (event == Lifecycle.Event.ON_STOP) {
-                chatBubbleController.onApplicationStop()
-                if (Build.VERSION.SDK_INT < Build.VERSION_CODES.S && Glia.isInitialized()) {
-                    notificationManager.startNotificationRemovalService()
+            when(event) {
+                Lifecycle.Event.ON_PAUSE -> {
+                    // Moved to on pause due to "IllegalStateException: Not allowed to start service app is in background"
+                    // Related bug ticket MOB-4011
+                    if (Build.VERSION.SDK_INT < Build.VERSION_CODES.S && Glia.isInitialized()) {
+                        notificationManager.startNotificationRemovalService()
+                    }
                 }
-            } else if (event == Lifecycle.Event.ON_DESTROY) {
-                chatBubbleController.onDestroy()
+                Lifecycle.Event.ON_STOP -> chatBubbleController.onApplicationStop()
+                Lifecycle.Event.ON_DESTROY -> chatBubbleController.onDestroy()
+                else -> { /* no-op */ }
             }
         }
     }