Skip to content

Commit 6dd503c

Browse files
fix: set exit code based on executed command (#193)
* fix: set exit code based on executed command * test: fix NUT assertion
1 parent 024530c commit 6dd503c

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,4 @@ node_modules
99
oclif.manifest.json
1010
oclif.lock
1111
npm-shrinkwrap.json
12+
.idea/

src/commands/force/lightning/lwc/test/run.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ export default class Run extends SfdxCommand {
5555
const scriptRet = this.runJest(args);
5656

5757
this.ux.log(messages.getMessage('logSuccess', [scriptRet.status.toString()]));
58+
process.exitCode=scriptRet.status;
5859
return {
5960
message: messages.getMessage('logSuccess', [scriptRet.status.toString()]),
6061
jestExitCode: scriptRet.status,

test/commands/lwc/test/run.nut.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ describe('lightning:lwc:test:run', () => {
8181
await fs.promises.writeFile(testPath, content);
8282

8383
const output = execCmd<RunResult>('force:lightning:lwc:test:run', {
84-
ensureExitCode: 0,
84+
ensureExitCode: 1,
8585
}).shellOutput.stderr;
8686
expect(output).to.include('Test Suites: 1 failed');
8787
expect(output).to.include('Tests: 1 failed');

test/commands/lwc/test/setup.nut.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ describe('lightning:lwc:test:setup', () => {
5555
content = await fs.promises.readFile(pjsonPath, 'utf-8');
5656
const forceignoreContent = fs.readFileSync(forceignorePath, 'utf-8');
5757
expect(forceignoreContent).to.include('**/__tests__/**');
58-
expect(content).to.include('"test:unit": "sfdx-lwc-jest --skipApiVersionCheck"');
59-
expect(content).to.include('"test:unit:coverage": "sfdx-lwc-jest --coverage --skipApiVersionCheck"');
60-
expect(content).to.include('"test:unit:debug": "sfdx-lwc-jest --debug --skipApiVersionCheck"');
58+
expect(content).to.include('"test:unit": "sfdx-lwc-jest"');
59+
expect(content).to.include('"test:unit:coverage": "sfdx-lwc-jest --coverage "');
60+
expect(content).to.include('"test:unit:debug": "sfdx-lwc-jest --debug "');
6161
expect(content).to.include('"@salesforce/sfdx-lwc-jest": "^');
6262
});
6363
});

0 commit comments

Comments
 (0)