Skip to content

Commit 3353626

Browse files
authored
fix: push to github even if signing verification fails (#237)
1 parent e5b55b0 commit 3353626

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

src/commands/npm/package/release.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -121,14 +121,16 @@ export default class Release extends SfdxCommand {
121121
}
122122
}
123123

124-
if (this.flags.sign && this.flags.verify && !this.flags.dryrun) {
125-
pkg.printStage('Verify Signed Packaged');
126-
pkg.verifySignature();
127-
}
128-
129-
if (!this.flags.dryrun) {
130-
pkg.printStage('Push Changes to Git');
131-
pkg.pushChangesToGit();
124+
try {
125+
if (this.flags.sign && this.flags.verify && !this.flags.dryrun) {
126+
pkg.printStage('Verify Signed Packaged');
127+
pkg.verifySignature();
128+
}
129+
} finally {
130+
if (!this.flags.dryrun) {
131+
pkg.printStage('Push Changes to Git');
132+
pkg.pushChangesToGit();
133+
}
132134
}
133135

134136
this.ux.log(pkg.getSuccessMessage());

0 commit comments

Comments
 (0)