Skip to content

Commit 413e20f

Browse files
authored
Merge pull request #610 from salesforcecli/ew/support-nightlies
Changes for nightly support
2 parents 50a0f4a + ec0de7b commit 413e20f

File tree

11 files changed

+526
-852
lines changed

11 files changed

+526
-852
lines changed

.github/CODEOWNERS

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
# These owners will be the default owners for everything in
22
# the repo. Unless a later match takes precedence,
3-
# @forcedotcom/pdt will be requested for
3+
# @salesforcecli/cli will be requested for
44
# review when someone opens a pull request.
5-
* @forcedotcom/pdt
6-
#ECCN:Open Source
5+
* @salesforcecli/cli
6+
7+
messages/ @jshackell-sfdc
8+
9+
#ECCN:Open Source

CHANGELOG.md

Lines changed: 171 additions & 652 deletions
Large diffs are not rendered by default.

command-snapshot.json

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,22 @@
2525
"alias": []
2626
},
2727
{
28-
"command": "cli:latestrc:build",
28+
"command": "cli:release:build",
2929
"plugin": "@salesforce/plugin-release-management",
30-
"flags": ["build-only", "json", "only", "patch", "pinned-deps", "rctag", "resolutions", "schema", "snapshot"],
31-
"alias": []
30+
"flags": [
31+
"build-only",
32+
"json",
33+
"only",
34+
"patch",
35+
"pinned-deps",
36+
"prerelease",
37+
"resolutions",
38+
"schema",
39+
"snapshot",
40+
"start-from-github-ref",
41+
"start-from-npm-dist-tag"
42+
],
43+
"alias": ["cli:latestrc:build"]
3244
},
3345
{
3446
"command": "cli:releasenotes",

messages/cli.latestrc.build.json

Lines changed: 0 additions & 19 deletions
This file was deleted.

messages/cli.release.build.json

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
{
2+
"description": "builds a new release from a designated starting point and optionally creates PR in Github",
3+
"examples": [
4+
"<%= config.bin %> <%= command.id %>",
5+
"<%= config.bin %> <%= command.id %> --patch",
6+
"<%= config.bin %> <%= command.id %> --start-from-npm-dist-tag latest-rc --patch",
7+
"<%= config.bin %> <%= command.id %> --start-from-github-ref 7.144.0",
8+
"<%= config.bin %> <%= command.id %> --start-from-github-ref main",
9+
"<%= config.bin %> <%= command.id %> --start-from-github-ref f476e8e",
10+
"<%= config.bin %> <%= command.id %> --start-from-github-ref main --prerelease beta",
11+
"<%= config.bin %> <%= command.id %> --build-only",
12+
"<%= config.bin %> <%= command.id %> --only @salesforce/plugin-source,@salesforce/plugin-info@1.2.3,@sf/config"
13+
],
14+
"flags": {
15+
"startFromNpmDistTag": "the npm dist-tag to start the release from, examples: nightly, latest-rc",
16+
"startFromGithubRef": "a Github ref to start the release from, examples: main, 7.144.0, f476e8e",
17+
"resolutions": "bump the versions of packages listed in the resolutions section",
18+
"pinnedDeps": "bump the versions of the packages listed in the pinnedDependencies section",
19+
"only": "only bump the version of the packages passed in, uses latest if version is not provided",
20+
"patch": "bump the release as a patch of an existing version, not a new minor version",
21+
"prerelease": "name of the prerelease to create, examples: dev, alpha",
22+
"buildOnly": "only build the release, do not git add/commit/push",
23+
"snapshot": "update the snapshots and commit them to the PR",
24+
"schema": "update the schemas and commit them to the PR"
25+
}
26+
}

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@
111111
"install": {
112112
"description": "utilities for CLI installation"
113113
},
114-
"latestrc": {
114+
"release": {
115115
"description": "utilities for building CLI releases"
116116
},
117117
"schemas": {
@@ -180,4 +180,4 @@
180180
"publishConfig": {
181181
"access": "public"
182182
}
183-
}
183+
}

src/codeSigning/SimplifiedSigning.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,16 @@ export const signVerifyUpload = async (signingRequest: SigningRequest): Promise<
9898
/**
9999
* Save the security items (publicKey and .sig file) to AWS based on the generates filenames
100100
*/
101-
const upload = async (input: SigningResponse): Promise<S3.PutObjectOutput[]> => Promise.all([
101+
const upload = async (input: SigningResponse): Promise<S3.PutObjectOutput[]> =>
102+
Promise.all([
102103
// signature file
103104
putObject(BUCKET, input.packageJsonSfdxProperty.signatureUrl.replace(`${BASE_URL}/`, ''), input.signatureContents),
104105
// publicKey
105106
putObject(BUCKET, input.packageJsonSfdxProperty.publicKeyUrl.replace(`${BASE_URL}/`, ''), input.publicKeyContents),
106107
]);
107108

108-
const getOneTimeUseKeys = (): Promise<KeyPair> => new Promise<KeyPair>((resolve, reject) => {
109+
const getOneTimeUseKeys = (): Promise<KeyPair> =>
110+
new Promise<KeyPair>((resolve, reject) => {
109111
generateKeyPair(
110112
'rsa',
111113
{
@@ -141,7 +143,8 @@ const getSignature = async (privateKey: string, dataToSignFilePath: string): Pro
141143
});
142144
};
143145

144-
const verify = async (dataToSignFilePath: string, publicKey: string, signature: string): Promise<boolean> => new Promise<boolean>((resolve, reject) => {
146+
const verify = async (dataToSignFilePath: string, publicKey: string, signature: string): Promise<boolean> =>
147+
new Promise<boolean>((resolve, reject) => {
145148
const verifier = createVerify(CRYPTO_LEVEL);
146149
const dataToVerifyStream = createReadStream(dataToSignFilePath, { encoding: 'binary' });
147150
dataToVerifyStream.pipe(verifier);

src/commands/cli/latestrc/build.ts

Lines changed: 0 additions & 164 deletions
This file was deleted.

0 commit comments

Comments
 (0)