Skip to content

Commit c9b5efd

Browse files
committed
Merge branch 'ew/build-rc-only-flag' of github.com:salesforcecli/plugin-release-management into ew/build-rc-only-flag
2 parents f6902d8 + 5219071 commit c9b5efd

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/package.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,9 @@ export class Package extends AsyncOptionalCreatable {
185185
for (const [key, value] of Object.entries(dependencies)) {
186186
if (key === name) {
187187
if (value.startsWith('npm:')) {
188-
// npm alias was passed, so we need to parse package name and version
188+
// npm alias was passed in as name, so we need to parse package name and version
189+
// e.g. passed in: "@sf/login"
190+
// dependency: "@sf/login": "npm:@salesforce/plugin-login@1.1.1"
189191
return {
190192
dependencyName: key,
191193
packageName: parseAliasedPackageName(value),
@@ -202,8 +204,10 @@ export class Package extends AsyncOptionalCreatable {
202204
};
203205
}
204206
}
205-
if (value.includes(`npm:${name}`)) {
206-
// package name was passed, but an alias is used for the dependency
207+
if (value.startsWith(`npm:${name}`)) {
208+
// package name was passed in as name, but an alias is used for the dependency
209+
// e.g. passed in: "@salesforce/plugin-login"
210+
// dependency: "@sf/login": "npm:@salesforce/plugin-login@1.1.1"
207211
return {
208212
dependencyName: key,
209213
packageName: name,

0 commit comments

Comments
 (0)