chore: use AuthInfo.update

Author: WillieRuemmele

src/commands/force/user/password/generate.ts

@@ -7,7 +7,6 @@
 import * as os from 'os';
 import { flags, FlagsConfig, SfdxCommand } from '@salesforce/command';
 import { Aliases, AuthInfo, Connection, Messages, Org, SfdxError, User, UserFields } from '@salesforce/core';
-import { Crypto } from '@salesforce/core/lib/crypto';
 
 Messages.importMessagesDirectory(__dirname);
 const messages = Messages.loadMessages('@salesforce/plugin-user', 'password.generate');
@@ -56,10 +55,9 @@ export class UserPasswordGenerateCommand extends SfdxCommand {
         // userId is used by `assignPassword` so we need to set it here
         authInfo.getFields().userId = fields.id;
         await user.assignPassword(authInfo, password);
-        const crypto = await Crypto.create();
         password.value((pass) => {
           this.passwordData.push({ username: aliasOrUsername, password: pass.toString('utf-8') });
-          authInfo.getFields().password = crypto.encrypt(pass.toString('utf-8'));
+          authInfo.update({ password: pass.toString('utf-8') });
         });
         await authInfo.save();
       } catch (e) {

test/commands/user/password/generate.test.ts

@@ -7,10 +7,9 @@
 
 import { $$, expect, test } from '@salesforce/command/lib/test';
 import { Aliases, AuthInfo, Connection, Org, User, AuthInfoConfig, Messages } from '@salesforce/core';
-import { spyMethod, StubbedType, stubInterface, stubMethod } from '@salesforce/ts-sinon';
+import { StubbedType, stubInterface, stubMethod } from '@salesforce/ts-sinon';
 import { MockTestOrgData } from '@salesforce/core/lib/testSetup';
 import { SecureBuffer } from '@salesforce/core/lib/secureBuffer';
-import { Crypto } from '@salesforce/core/lib/crypto';
 
 Messages.importMessagesDirectory(__dirname);
 const messages = Messages.loadMessages('@salesforce/plugin-user', 'password.generate');
@@ -19,7 +18,6 @@ describe('force:user:password:generate', () => {
   let authInfoStub: StubbedType<AuthInfo>;
   let authInfoConfigStub: StubbedType<AuthInfoConfig>;
   const testData = new MockTestOrgData();
-  let cryptoSpy;
 
   async function prepareStubs(throws = false) {
     const authFields = await testData.getConfig();
@@ -37,8 +35,6 @@ describe('force:user:password:generate', () => {
       id: '0052D0000043PawWWR',
     });
 
-    cryptoSpy = spyMethod($$.SANDBOX, Crypto.prototype, 'encrypt');
-
     const secureBuffer: SecureBuffer<void> = new SecureBuffer<void>();
     secureBuffer.consume(Buffer.from('abc', 'utf8'));
     stubMethod($$.SANDBOX, User, 'generatePasswordUtf8').returns(secureBuffer);
@@ -71,7 +67,7 @@ describe('force:user:password:generate', () => {
       ];
       const result = JSON.parse(ctx.stdout).result;
       expect(result).to.deep.equal(expected);
-      expect(cryptoSpy.calledTwice).to.be.true;
+      expect(authInfoStub.update.callCount).to.equal(2);
     });
 
   test
@@ -82,7 +78,7 @@ describe('force:user:password:generate', () => {
       const expected = [{ username: 'defaultusername@test.com', password: 'abc' }];
       const result = JSON.parse(ctx.stdout).result;
       expect(result).to.deep.equal(expected);
-      expect(cryptoSpy.calledOnce).to.be.true;
+      expect(authInfoStub.update.callCount).to.equal(1);
     });
 
   test
@@ -95,6 +91,6 @@ describe('force:user:password:generate', () => {
       expect(result.message).to.equal(messages.getMessage('noSelfSetError'));
       expect(result.status).to.equal(1);
       expect(result.name).to.equal('noSelfSetError');
-      expect(cryptoSpy.callCount).to.equal(0);
+      expect(authInfoStub.update.callCount).to.equal(0);
     });
 });