chore: fixed varargs on user:create, fixed list

Author: WillieRuemmele

messages/create.json

@@ -2,7 +2,7 @@
   "description": "create a user for a scratch org",
   "examples": [
     "sfdx force:user:create",
-    "sfdx force:user:create -a testuser1 -f config/project-user-def.json",
+    "sfdx force:user:create -a testuser1 -f config/project-user-def.json profileName='Chatter Free User'",
     "sfdx force:user:create username=testuser1@my.org email=me@my.org permsets=DreamHouse",
     "sfdx force:user:create -f config/project-user-def.json email=me@my.org generatepassword=true"
   ],

src/commands/force/user/create.ts

@@ -168,9 +168,7 @@ export class UserCreateCommand extends SfdxCommand {
 
     if (this.varargs) {
       Object.keys(this.varargs).forEach((key) => {
-        if (defaultFields[key]) {
-          defaultFields[this.lowerFirstLetter(key)] = this.varargs[key];
-        }
+        defaultFields[this.lowerFirstLetter(key)] = this.varargs[key];
       });
     }
 

src/commands/force/user/list.ts

@@ -6,7 +6,7 @@
  */
 import * as os from 'os';
 import { SfdxCommand } from '@salesforce/command';
-import { Messages, Connection, Aliases, AuthInfo } from '@salesforce/core';
+import { Messages, Connection, Aliases, AuthInfo, ConfigAggregator } from '@salesforce/core';
 
 Messages.importMessagesDirectory(__dirname);
 const messages = Messages.loadMessages('@salesforce/plugin-user', 'list');
@@ -38,14 +38,16 @@ export class UserListCommand extends SfdxCommand {
     const userInfos: UserInfo = await this.buildUserInfos();
     const profileInfos: ProfileInfo = await this.buildProfileInfos();
     const userAuthData: AuthInfo[] = await this.org.readUserAuthFiles();
-
-    const alias = await Aliases.fetch(this.flags.targetusername);
+    const aliases = await Aliases.create(Aliases.getDefaultOptions());
 
     const authList: AuthList[] = userAuthData.map((authData) => {
       const username = authData.getUsername();
-
+      // if they passed in a alias and it maps to something we have an Alias.
+      const alias = aliases.getKeysByValue(authData.getUsername())[0];
+      const configAgg = ConfigAggregator.getInstance();
+      const defaultUser = configAgg.getLocalConfig().get('defaultusername');
       return {
-        defaultMarker: authData.getFields().scratchAdminUsername ? '' : '(A)',
+        defaultMarker: defaultUser === username ? '(A)' : '',
         alias: alias || '',
         username,
         profileName: profileInfos[userInfos[username].ProfileId],

test/commands/user/list.test.ts

@@ -28,7 +28,7 @@ describe('force:user:list', () => {
       },
     ]);
     stubMethod($$.SANDBOX, Org.prototype, 'getOrgId').returns('abc123');
-    stubMethod($$.SANDBOX, Aliases, 'fetch').resolves('testAlias');
+    stubMethod($$.SANDBOX, Aliases.prototype, 'getKeysByValue').returns(['testAlias']);
     stubMethod($$.SANDBOX, Connection.prototype, 'query')
       .withArgs('SELECT username, profileid, id FROM User')
       .resolves({
@@ -77,7 +77,7 @@ describe('force:user:list', () => {
       // testUser1@test.com is aliased to testUser
       const expected = [
         {
-          defaultMarker: '(A)',
+          defaultMarker: '',
           alias: 'testAlias',
           username: 'testuser@test.com',
           profileName: 'Analytics Cloud Integration User',