fix: remove dead code

Author: mdonnalley

messages/messages.md

@@ -117,10 +117,6 @@ Set varargs with this format: key=value or key="value with spaces"
 
 Found duplicate argument %s.
 
-# warning.arrayInputFormat
-
-The input format for array arguments has changed. Use this format: --array-flag value1 --array-flag value2 --array-flag value3
-
 # flags.flags-dir.summary
 
 Import flag values from a directory.

src/compatibility.ts

@@ -6,7 +6,7 @@
  */
 
 import { Flags } from '@oclif/core';
-import { Lifecycle, Messages } from '@salesforce/core';
+import { Messages } from '@salesforce/core';
 import { orgApiVersionFlag } from './flags/orgApiVersion.js';
 import { optionalHubFlag, optionalOrgFlag, requiredHubFlag, requiredOrgFlag } from './flags/orgFlags.js';
 
@@ -98,17 +98,4 @@ export type ArrayWithDeprecationOptions = {
 export const arrayWithDeprecation = Flags.custom<string[], ArrayWithDeprecationOptions>({
   multiple: true,
   delimiter: ',',
-  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-  // @ts-expect-error parse expects to return string[] but we need to return string.
-  // This is a weird consequence of implementing an array flag. The oclif parser splits the input (e.g. "thing1,thing2")
-  // on the delimiter and passes each value individually to the parse function. However, the return type needs to be
-  // string[] so that upstream consumers have the correct flag typings.
-  parse: async (input, ctx) => {
-    const inputParts = ctx.token.input.split(',').map((i) => i.trim());
-    if (inputParts.length > 1) {
-      await Lifecycle.getInstance().emitWarning(messages.getMessage('warning.arrayInputFormat'));
-    }
-
-    return input;
-  },
 });

test/unit/compatibility.test.ts

@@ -0,0 +1,45 @@
+/*
+ * Copyright (c) 2024, salesforce.com, inc.
+ * All rights reserved.
+ * Licensed under the BSD 3-Clause license.
+ * For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause
+ */
+import { expect } from 'chai';
+import { Command, Interfaces } from '@oclif/core';
+import { arrayWithDeprecation } from '../../src/compatibility.js';
+
+describe('arrayWithDeprecation', () => {
+  class TestCommand extends Command {
+    public static flags = {
+      things: arrayWithDeprecation({
+        char: 'a',
+        description: 'api version for the org',
+      }),
+    };
+
+    public async run(): Promise<Interfaces.InferredFlags<typeof TestCommand.flags>> {
+      const { flags } = await this.parse(TestCommand);
+      return flags;
+    }
+  }
+
+  it('should split the flags on comma', async () => {
+    const result = await TestCommand.run(['--things', 'a,b,c']);
+    expect(result.things).to.deep.equal(['a', 'b', 'c']);
+  });
+
+  it('should split the flags on comma and ignore spaces', async () => {
+    const result = await TestCommand.run(['--things', 'a, b, c']);
+    expect(result.things).to.deep.equal(['a', 'b', 'c']);
+  });
+
+  it('should not split on escaped commas', async () => {
+    const result = await TestCommand.run(['--things', 'a\\,b,c']);
+    expect(result.things).to.deep.equal(['a,b', 'c']);
+  });
+
+  it('should allow multiple flag inputs', async () => {
+    const result = await TestCommand.run(['--things', 'a', '--things', 'b', '--things', 'c']);
+    expect(result.things).to.deep.equal(['a', 'b', 'c']);
+  });
+});