Skip to content

Commit a10aec6

Browse files
authored
fix: bump oclif/table (#643)
* fix: bump oclif/table * fix: remove old deps * test: update table tests * ci: rm table before nuts
1 parent 4cea4fc commit a10aec6

File tree

4 files changed

+14
-21
lines changed

4 files changed

+14
-21
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
with:
3939
packageName: '@salesforce/sf-plugins-core'
4040
externalProjectGitUrl: 'https://github.com/salesforcecli/plugin-deploy-retrieve'
41-
preBuildCommands: 'shx rm -rf node_modules/@oclif/core node_modules/@salesforce/kit node_modules/@salesforce/core node_modules/@salesforce/ts-types node_modules/@salesforce/cli-plugins-testkit'
41+
preBuildCommands: 'shx rm -rf node_modules/@oclif/core node_modules/@oclif/table node_modules/@salesforce/kit node_modules/@salesforce/core node_modules/@salesforce/ts-types node_modules/@salesforce/cli-plugins-testkit'
4242
command: ${{ matrix.command }}
4343
os: ${{ matrix.os }}
4444
secrets: inherit
@@ -67,7 +67,7 @@ jobs:
6767
with:
6868
packageName: '@salesforce/sf-plugins-core'
6969
externalProjectGitUrl: 'https://github.com/salesforcecli/${{matrix.repo}}'
70-
preBuildCommands: 'shx rm -rf node_modules/@oclif/core node_modules/@salesforce/kit node_modules/@salesforce/core node_modules/@salesforce/ts-types'
70+
preBuildCommands: 'shx rm -rf node_modules/@oclif/core node_modules/@oclif/table node_modules/@salesforce/kit node_modules/@salesforce/core node_modules/@salesforce/ts-types'
7171
command: yarn test:nuts
7272
os: ${{ matrix.os }}
7373
secrets: inherit

package.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,12 @@
4646
"@inquirer/confirm": "^3.1.22",
4747
"@inquirer/password": "^2.2.0",
4848
"@oclif/core": "^4.0.27",
49-
"@oclif/table": "^0.3.0",
49+
"@oclif/table": "^0.3.2",
5050
"@salesforce/core": "^8.5.1",
5151
"@salesforce/kit": "^3.2.3",
5252
"@salesforce/ts-types": "^2.0.12",
5353
"ansis": "^3.3.2",
5454
"cli-progress": "^3.12.0",
55-
"natural-orderby": "^3.0.2",
56-
"slice-ansi": "^7.1.0",
57-
"string-width": "^7.2.0",
5855
"terminal-link": "^3.0.0"
5956
},
6057
"devDependencies": {

test/unit/ux/ux.test.ts

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,9 @@ describe('Ux', () => {
3232
ux.table({ data: [{ key: 'foo', value: 'bar' }], title: 'Title' });
3333
});
3434
expect(stdout.replaceAll(' \n', '\n').trimEnd()).to.equal(`Title
35-
┌─────┬───────┐
36-
│ Key │ Value │
37-
├─────┼───────┤
38-
│ foo │ bar │
39-
└─────┴───────┘`);
35+
Key Value
36+
------------
37+
foo bar`);
4038
});
4139

4240
it('should not log anything if output is not enabled', async () => {
@@ -56,11 +54,9 @@ describe('Ux', () => {
5654
ux.table(opts);
5755
});
5856
expect(stdout.replaceAll(' \n', '\n').trimEnd()).to.equal(`Title
59-
┌─────┬───────┐
60-
│ Key │ Value │
61-
├─────┼───────┤
62-
│ foo │ bar │
63-
└─────┴───────┘`);
57+
Key Value
58+
------------
59+
foo bar`);
6460
});
6561

6662
it('should not log anything if output is not enabled', async () => {

yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -582,10 +582,10 @@
582582
wordwrap "^1.0.0"
583583
wrap-ansi "^7.0.0"
584584

585-
"@oclif/table@^0.3.0":
586-
version "0.3.0"
587-
resolved "https://registry.yarnpkg.com/@oclif/table/-/table-0.3.0.tgz#b87ba5d20e7e84a1d4744e68c64093dbc8bd8de9"
588-
integrity sha512-HzUUyNcoEzfyvzzXL1evLZmiMBZ2SnH41lNHpoKJZJR4uCdiMkOzlkLf9M326qLmRJTDpKnUHgIZD778T647gg==
585+
"@oclif/table@^0.3.2":
586+
version "0.3.2"
587+
resolved "https://registry.yarnpkg.com/@oclif/table/-/table-0.3.2.tgz#192a310488af67a7341ba203a0e3a0d67f1d8693"
588+
integrity sha512-H8B41sRuXByT4E3ROSICbiQBbZDD3Kw30vYkJlPvKbE5QGEd11hPo+P9ahdGLA3AY0SkTflfTily8fFhHT0WDA==
589589
dependencies:
590590
"@oclif/core" "^4"
591591
"@types/react" "^18.3.12"
@@ -4980,7 +4980,7 @@ string-width@^5.0.1, string-width@^5.1.2:
49804980
emoji-regex "^9.2.2"
49814981
strip-ansi "^7.0.1"
49824982

4983-
string-width@^7.0.0, string-width@^7.2.0:
4983+
string-width@^7.0.0:
49844984
version "7.2.0"
49854985
resolved "https://registry.yarnpkg.com/string-width/-/string-width-7.2.0.tgz#b5bb8e2165ce275d4d43476dd2700ad9091db6dc"
49864986
integrity sha512-tsaTIkKW9b4N+AEj+SVA+WhJzV7/zMhcSu78mLKWSk7cXMOSHsBKFWUs0fWwq8QyK3MgJBQRX6Gbi4kYbdvGkQ==

0 commit comments

Comments
 (0)