Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #[doc(hidden)] plumbing module #781

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Mar 28, 2025

No description provided.

Copy link

netlify bot commented Mar 28, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit f9b3a1b
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/67ee66d9887cc80008215a5f

Copy link

codspeed-hq bot commented Mar 28, 2025

CodSpeed Performance Report

Merging #781 will degrade performances by 8.35%

Comparing Veykril:veykril/push-uqomyykvlvol (f9b3a1b) with master (9b51992)

Summary

❌ 4 (👁 4) regressions
✅ 8 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 amortized[Input] 3.5 µs 3.6 µs -4.32%
👁 amortized[InternedInput] 3.3 µs 3.6 µs -8.35%
👁 amortized[SupertypeInput] 4 µs 4.3 µs -5.95%
👁 new[InternedInput] 5.6 µs 6 µs -6.01%

@Veykril Veykril force-pushed the veykril/push-uqomyykvlvol branch from 70c3665 to f9b3a1b Compare April 3, 2025 10:45
@Veykril Veykril enabled auto-merge April 3, 2025 10:46
@Veykril
Copy link
Member Author

Veykril commented Apr 3, 2025

I am going to acknowledge these regressions, 1.86 just released and a lot of inlining of functions has changed, so this is just noies from compiler changes.

@Veykril Veykril added this pull request to the merge queue Apr 3, 2025
Merged via the queue into salsa-rs:master with commit 395b29d Apr 3, 2025
11 checks passed
@Veykril Veykril deleted the veykril/push-uqomyykvlvol branch April 3, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants