Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster_mode in returner/token module #19

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Conversation

hackruu
Copy link
Contributor

@hackruu hackruu commented Feb 14, 2025

Fix missing password passing in cluster mode, change StrictRedisCluster to RedisCluster as it's deleted in 2019

What does this PR do?

What issues does this PR fix or reference?

Fixes:
#18

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.72%. Comparing base (7b03ca1) to head (45a9f94).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/saltext/redis/returners/redis_return.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   77.82%   77.72%   -0.10%     
==========================================
  Files          15       15              
  Lines        1001     1001              
  Branches       60       60              
==========================================
- Hits          779      778       -1     
- Misses        207      208       +1     
  Partials       15       15              
Flag Coverage Δ
Linux 77.72% <50.00%> (-0.10%) ⬇️
macOS 60.41% <50.00%> (-0.13%) ⬇️
project 62.25% <50.00%> (-0.19%) ⬇️
py310 77.62% <50.00%> (-0.10%) ⬇️
py39 77.72% <50.00%> (-0.10%) ⬇️
salt_3006_9 77.72% <50.00%> (-0.10%) ⬇️
salt_3007_1 77.62% <50.00%> (-0.10%) ⬇️
tests 96.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkubb lkubb changed the title Fix missing password passing in cluster mode, change StrictRedisCluster to RedisCluster Fix cluster_mode in returner/token module Feb 14, 2025
@lkubb lkubb merged commit dc50168 into salt-extensions:main Feb 14, 2025
22 checks passed
@lkubb lkubb linked an issue Feb 14, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] RedisCluster is not working
2 participants