Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

리팩토링 고려할 부분 찾기 #10

Open
sanhee opened this issue Mar 26, 2021 · 9 comments
Open

리팩토링 고려할 부분 찾기 #10

sanhee opened this issue Mar 26, 2021 · 9 comments
Labels
리팩토링
Milestone
미션1 리팩토링

Comments

@sanhee
Copy link
Owner

sanhee commented Mar 26, 2021

리팩토링 할만한 부분을 찾아보고 답글로 해당 부분을 남겨둔다.
그리고 확인 후에 나중에 처리한다.
@sanhee
Copy link
Owner Author

sanhee commented Mar 26, 2021

#9 (comment)
#9 (comment)
#9 (comment)
#9 (comment)
#9 (comment)
#9 (comment)

@Dae-Hwa Dae-Hwa pinned this issue Mar 30, 2021
@Dae-Hwa
Copy link
Collaborator

Dae-Hwa commented Mar 30, 2021

#12 (comment)
#12 (comment)

@Dae-Hwa
Copy link
Collaborator

Dae-Hwa commented Apr 1, 2021

#16 (comment)
#16 (comment)
#16 (comment)
#16 (comment)

Dae-Hwa pushed a commit that referenced this issue Jul 19, 2021
@wheejuni
Merge pull request #10 from sanhee/implement-structure
ae4a8f4 
[프레디, 노을] 1단계 준비 과정
@Dae-Hwa
Copy link
Collaborator

Dae-Hwa commented Aug 12, 2021

HashMap -> HashMap 으로 변경하기

Dae-Hwa added a commit that referenced this issue Aug 12, 2021
@Dae-Hwa
Revert "fix: HashMap에 제네릭 추가"
e5452ee 
This reverts commit 0d21397.

#10 (comment) 에서
처리하기로 결정
@Dae-Hwa
Copy link
Collaborator

Dae-Hwa commented Aug 17, 2021

불필요한 equalTo 확인

@Dae-Hwa
Copy link
Collaborator

Dae-Hwa commented Aug 17, 2021

테스트 케이스 텍스트가 아닌 객체 사용하도록 수정

@Dae-Hwa
Copy link
Collaborator

Dae-Hwa commented Aug 17, 2021

javadocs 수정

@Dae-Hwa
Copy link
Collaborator

Dae-Hwa commented Aug 17, 2021

BufferedReader 깔끔하게

@Dae-Hwa Dae-Hwa added this to the 미션1 리팩토링 milestone Aug 18, 2021
@Dae-Hwa
Copy link
Collaborator

Dae-Hwa commented Aug 19, 2021

상대경로 -> 절대경로

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
리팩토링
Projects
None yet
Milestone
미션1 리팩토링
Development

No branches or pull requests
2 participants
@Dae-Hwa @sanhee