This repository was archived by the owner on May 29, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 212
Pass timestamp option for svgo(node engine) #358
Open
garyanikin
wants to merge
3
commits into
sapegin:master
Choose a base branch
from
garyanikin:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,8 @@ var path = require('path'); | |
var grunt = require('grunt'); | ||
var parseXMLString = require('xml2js').parseString; | ||
var wf = require('../tasks/util/util'); | ||
var crypto = require('crypto'); | ||
var Promise = require('promise'); | ||
|
||
function find(haystack, needle) { | ||
return haystack.indexOf(needle) !== -1; | ||
|
@@ -930,6 +932,52 @@ exports.webfont = { | |
test.ok(fs.existsSync('test/tmp/filename_length/icons.html')); | ||
|
||
test.done(); | ||
} | ||
}, | ||
|
||
// If font created multiple times with same value as timestamp option | ||
// then md5 of created files must be the same too | ||
timestamp_same: function (test) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wouldn’t it be easier to compare file contents? ;-) |
||
var promise_1 = new Promise(function(resolve, reject) { | ||
fs.readFile('test/tmp/timestamp_same/same_1.ttf', function (err, data) { | ||
resolve(crypto.createHash('md5').update(data, 'utf8').digest('hex')); | ||
}); | ||
}); | ||
|
||
var promise_2 = new Promise(function(resolve, reject) { | ||
fs.readFile('test/tmp/timestamp_same/same_2.ttf', function (err, data) { | ||
resolve(crypto.createHash('md5').update(data, 'utf8').digest('hex')); | ||
}); | ||
}); | ||
|
||
Promise.all([promise_1, promise_2]) | ||
.then(function(data) { | ||
// md5 must be the same | ||
test.ok(data[0] === data[1]); | ||
test.done(); | ||
}); | ||
}, | ||
|
||
// If font created multiple times with different value as timestamp option | ||
// then md5 of created files must be different | ||
timestamp_different: function (test) { | ||
var promise_1 = new Promise(function(resolve, reject) { | ||
fs.readFile('test/tmp/timestamp_different/different_1.ttf', function (err, data) { | ||
resolve(crypto.createHash('md5').update(data, 'utf8').digest('hex')); | ||
}); | ||
}); | ||
|
||
var promise_2 = new Promise(function(resolve, reject) { | ||
fs.readFile('test/tmp/timestamp_different/different_2.ttf', function (err, data) { | ||
resolve(crypto.createHash('md5').update(data, 'utf8').digest('hex')); | ||
}); | ||
}); | ||
|
||
Promise.all([promise_1, promise_2]) | ||
.then(function(data) { | ||
// md5 must be the different | ||
test.ok(data[0] !== data[1]); | ||
test.done(); | ||
}); | ||
}, | ||
|
||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Promises are supported since Node 0.12, so you don’t need a polyfill.