Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More work on the teambuilder #234

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

CarlosFdez
Copy link
Collaborator

List of changes include:

  • Fixed team select dropdown not updating when the last team is removed. Added build a team
  • Clicking Find Battle without a team redirects to the Teambuilder

On the teambuilder itself

  • Move descriptions. Currently more verbose than desired but its a start.
  • Highlight selected move rows. Clicking a selected move in the table removes it from the selected moves
  • Added a mega forme dropdown. Currently it only attaches the item. Later we will need to implement a mega forme preview
  • EV locking, you can go above 510 max EVs when its locked. Locks can be toggled off, but the setting isn't saved yet.
  • Collapse the selected moves list on insert/remove. Only empty inputs are collapsed.

@@ -230,12 +237,21 @@ class @Pokemon extends Backbone.Model
"Healthy"

canMegaEvolve: ->
# TODO: Refactor this to use getPossibleMegaForme()
# I didn't feel like making the change and testing it while implementing getPossibleMegaForme()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically I didn't want to have to test the battle system to make a change for the teambuilder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants