-
Notifications
You must be signed in to change notification settings - Fork 4
Dangerous new Order Status "On hold" #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @andreDane, We are looking into it and we are working towards a resolution. |
Hi @andreDane We have now improved the flow with this logic:
Please let us know if you want to share any other feedbacks regarding our Plugin |
Hi @keeara ,
![]() "Mantenere scorte (minuti)"
Beyond my opinions, I would recommend taking a look at how Stripe and Paypal plugins work as instant payment methods like Satispay: none of these use the On hold status. References (from WooCommerce): |
Ciao @andreDane You're absolutely right, but we have a conflict at the moment between our Plugin and WooCommerce. (it's regarding the pending orders woocommerce core-logic and our plugin logic) We do think your point is absolutely right, that's why we have in the backlog the plugin-rework. This just to confirm what you're stating and that we 'understand' what's wrong with the Plugin. We're aware of it and we're going to end all with a completely new product. For any suggestion, feedback, or question, please do not hesitate to reach us out! |
Hi @keeara , |
Hi @keeara , |
Hi! Any update on this? Thank you. |
Hi, In my opinion, the proper way to handle this would be to set the order status to Pending Payment. If the current status is needed to track the sync with Satispay, then perhaps it would be better not to rely on the WooCommerce order status, but instead use a custom order meta to store the data needed for the Satispay sync. As @andreDane clearly explained when opening the issue, the On Hold status is used by WooCommerce to handle a different payment flow. Thank you in advance. |
Hi,
I’m writing to report an issue with the new Order management behaviour with the last update to v2.2.1.
For context, before this update this is what happened to new orders:
After last release, step 1 changed:
Well, I think this new behaviour is very dangerous, because the “On hold” status is used in a improper way: this status should be used for deferred payment methods.
For example, BACS is a payment method where users make payment, but it needs 1-2 days for the Shop Manager to receive the funds: in this case it is right to confirm the order and therefore to reserve the products reducing the stock, because the payment has been done. When funds will be received, the order will go to “Processing” status and so the shop manager will then prepare the order for the shipment.
But as you know, this is not the way Satispay works: Satispay payments are instantaneous, so there is no need to reserve stock (indeed, to do so would be dangerous, see next paragraph) or confirm order because funds are immediately received from Shop Manager that will prepare the order right after the user creates it.
Adding the “On hold” status will generate the following bug:
Shop Manager has an “On hold” order, without a real reason because there is no payment to await for, and has products stock reserved for no reason (what if they were the last in stock… other users nor the same user himself wouldn’t be able to buy those… very bad).
As you can see from the last point, this update could generate also an important economic damage to the store.
Please, give a look at the definitions WooCommerce itself give for all the Order statuses:
The text was updated successfully, but these errors were encountered: