fixed testing harness: made some amends, changed nightly version, used cargo-binstall for cross install

Author: sayantn

.github/workflows/common.yml

@@ -173,7 +173,8 @@ jobs:
     with:
       target: ${{ matrix.target }}
 
-  test-build-std:
+  test-nightly-only:
+    # These environments have cross support, but don't have rust-std, so cross has to build core, so, nightly-only
     strategy:
       fail-fast: false
       matrix:
@@ -190,5 +191,4 @@ jobs:
     uses: ./.github/workflows/runtest.yml
     with:
       target: ${{ matrix.target }}
-      channel: nightly
-      build-std: true
+      channel: nightly

.github/workflows/runtest.yml

@@ -12,10 +12,6 @@ on:
         required: false
         type: string
         default: ''
-      build-std:
-        required: false
-        type: boolean
-        default: false
 
 jobs:
   test:
@@ -33,20 +29,32 @@ jobs:
           toolchain: ${{ inputs.channel }}
           profile: minimal
           override: true
+        if: inputs.channel != nightly
+
+      # the nightly 2024-05-18 has a bug where it is not understanding -fuse-ld=lld
+      - name: Install Rust
+        uses: actions-rs/toolchain@v1
+        with:
+          toolchain: nightly-2024-05-11
+          profile: minimal
+          override: true
+        if: inputs.channel == 'nightly'
 
       - run: ${{ format('echo "{0}" >> $GITHUB_ENV', inputs.env-vars) }}
 
       - name: Build
         uses: actions-rs/cargo@v1
         with:
-          use-cross: true
           command: build
-          args: --target ${{ inputs.target }} ${{ inputs.channel == 'nightly' && '--features=nightly' || '' }} ${{ inputs.build-std && '-Z build-std=core' || '' }}
+          args: --target ${{ inputs.target }} ${{ inputs.channel == 'nightly' && '--features=nightly' || '' }}
+
+      # Install cross via cargo-binstall to save time
+      - uses: cargo-bins/cargo-binstall@main
+      - run: cargo binstall cross
 
       - name: Test
         uses: actions-rs/cargo@v1
         with:
           use-cross: true
           command: test
-          args: --target ${{ inputs.target }} ${{ inputs.channel == 'nightly' && '--features=nightly' || '' }}
-
+          args: --target ${{ inputs.target }} ${{ inputs.channel == 'nightly' && '--features=nightly' || '' }}