Feature/Android #494
Feature/Android #494
Conversation
| super().__init__() | ||
|
|
||
| # function to calculate an incremental weighted average of the weights | ||
| def increment_average( |
There was a problem hiding this comment.
Why do we need two version of this function? The implementation in increment_average_add looks more efficient (vectorized). Why not have only that one (as 'increment_average')?
There was a problem hiding this comment.
Think this is very much still in dev state. Will convert to draft.
| from .helperbase import HelperBase | ||
|
|
||
|
|
||
| class Helper(HelperBase): |
There was a problem hiding this comment.
Maybe more a philosophical question, but there seems to be nothing here specific to Android. It is more that we are here assuming that the model parameters have been serialized to a json document, and that that document can be cast to a numpy.array? Maybe add those assumptions to the readme? I guess what I am after is if it should be named "androidhelper" or something else (jsonhelper?)
|
@niklastheman This one should be closed now, right? You merged the android helper in a separate PR, right? |
Yes, this is obsolete. |
|
Has been solved in other PR. |
Android helper added