Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/SK-623 | Validations objects should store proper timestamp #526

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Feature/SK-623 | Validations objects should store proper timestamp #526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fedn/fedn/network/clients/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,9 +652,9 @@ def process_request(self):
validation.receiver.role = request.sender.role
validation.model_id = str(request.model_id)
validation.data = json.dumps(metrics)
self.str = str(datetime.now())
validation.timestamp = self.str
validation.timestamp.GetCurrentTime()
validation.correlation_id = request.correlation_id

_ = self.combinerStub.SendModelValidation(
validation, metadata=self.metadata)

Expand Down
4 changes: 3 additions & 1 deletion fedn/fedn/network/grpc/fedn.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ syntax = "proto3";

package grpc;

import "google/protobuf/timestamp.proto";

message Response {
Client sender = 1;
string response = 2;
Expand Down Expand Up @@ -83,7 +85,7 @@ message ModelValidation {
string model_id = 3;
string data = 4;
string correlation_id = 5;
string timestamp = 6;
google.protobuf.Timestamp timestamp = 6;
string meta = 7;
}

Expand Down
Loading
Loading