Feature/SK-669 | Store session id on status (event) and validation objects #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
niklastheman
commented
Feb 12, 2024
niklastheman
commented
- Client status log stores session id
- Validation objects stores session id
Wrede
approved these changes
Feb 13, 2024
| @@ -434,7 +434,7 @@ def _listen_to_task_stream(self): | |||
| if request.sender.role == fedn.COMBINER: | |||
| # Process training request | |||
| self._send_status("Received model update request.", log_level=fedn.Status.AUDIT, | |||
| type=fedn.StatusType.MODEL_UPDATE_REQUEST, request=request) | |||
| type=fedn.StatusType.MODEL_UPDATE_REQUEST, request=request, sesssion_id=request.session_id) | |||
| logger.info("Received model update request of type {} for model_id {}".format(request.type, request.model_id)) | |||
There was a problem hiding this comment.
can't you add the session_id in this log info as well?
There was a problem hiding this comment.
I thought about that too. The way I see it, when a task stream is started, the session doesn't necessarily exists so I figured I skip it. If I'm wrong we can add it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.