Feature/SK-544 | Server side changes for c++ client #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahellander
reviewed
Feb 27, 2024
| metadata = json.loads(model_update.meta) | ||
| if 'config' in metadata.keys(): | ||
| # Used in Python client | ||
| config = json.loads(metadata['config']) |
There was a problem hiding this comment.
Why do we need to support both versions of the message? Why not just introduce the new config?
There was a problem hiding this comment.
because of backward compability
ahellander
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces protobuf changes. pakage is now called "fedn" instead of "grpc" (caused conflicts in protoc c++ lib). Added field "config" to ModelUpdate message instead of processing nested json in "meta" field. Added changes to AggregatorBase to still allow the nested json and the new field.