Bugfix/sk 752 #565
Merged
Bugfix/sk 752 #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrede
requested changes
Apr 12, 2024
| self.detach() | ||
| logger.error("GRPC hearbeat: Token expired. Disconnecting.") | ||
| self.disconnect() | ||
| sys.exit("Unauthorized. Token expired. Please obtain a new token.") |
There was a problem hiding this comment.
Why? this will break the client trying to refresh token?
There was a problem hiding this comment.
Yes, was thinking about that, but currently the client is not trying to refresh the token, right? So for now the right things seems to be to disconnect?
There was a problem hiding this comment.
no that's not right they will try to refresh tokens, if you ask for new assignment and the token has expired it will try to get a new one. But only when calling REST-API
Wrede
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix - missing self.attach() upon client reconnection attempt.
Also introduces the logic change that if the reason for a client being disconnected is Token expirations, no reconnection attempts are made and the client exits.
Closes SK-752.