Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/SK-875 | Fix health check in combiner #618

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Bug/SK-875 | Fix health check in combiner #618

merged 1 commit into from
Jun 7, 2024

Conversation

sztoor
Copy link
Member

@sztoor sztoor commented Jun 5, 2024

…om 2sec to 20sec. We don't need any extra flags.

Description

…om 2sec to 20sec. We don't need any extra flags.
@sztoor
Copy link
Member Author

sztoor commented Jun 5, 2024

All in one combiner fixed.

Copy link
Member

@Wrede Wrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when timeout < interval?

@sztoor
Copy link
Member Author

sztoor commented Jun 7, 2024

The "interval" is the gap/pause to start the checks. According to the current settings, the check will start after 20 seconds and will be terminated when the timeout hits. If something fails, the check will start again after 20 seconds. Once it starts, it needs to finish before the timeout; otherwise, it will be terminated again. This process will be repeated for the number of retries set.

@Wrede Wrede changed the title Combiner health check is now fixed by increasing the interval time from 2sec to 20sec. We don't need any extra flags. Bug/SK-875 | Fix health check in combiner Jun 7, 2024
@Wrede Wrede self-requested a review June 7, 2024 11:01
@Wrede Wrede merged commit 0628178 into master Jun 7, 2024
11 checks passed
@Wrede Wrede deleted the bug/SK-875 branch June 7, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants