Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/SK-1473 | Store memory and cpu utilisation of clients #837

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

niklastheman
Copy link
Contributor

Send cpu and memory utilisation via send heart beat

@niklastheman niklastheman requested review from Wrede and ahellander March 5, 2025 13:23
@github-actions github-actions bot added minor feature New feature or request and removed minor labels Mar 5, 2025
Copy link
Member

@ahellander ahellander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe it should be named something else that "Analytics" in the future, but works for now.

Copy link
Member

@Wrede Wrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but I don't like the name Analytic

@Wrede
Copy link
Member

Wrede commented Mar 5, 2025

obs that you compiled with a newer protobuf version, I don't think there should be any problem but it might introduce breaking changes between client=0.23 and current changes.

@niklastheman niklastheman merged commit 6b5ccb6 into master Mar 5, 2025
21 checks passed
@niklastheman niklastheman deleted the feature/SK-1473 branch March 5, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants