Skip to content

ci: merge coverage with regular CI tests #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

Borda
Copy link

@Borda Borda commented Apr 6, 2024

This could simplify maintenance as the testing and reporting coverage workflows are almost the same, so let's add reporting coverage to the main one and drop the additional/duplicate...

@jarrodmillman
Copy link
Member

We have the separate because we run the tests on multiple platforms and multiple python versions, but we only want to run coverage reports on one platform and one python version. This is the standard pattern on most Scientific Python projects.

@jarrodmillman jarrodmillman marked this pull request as draft April 6, 2024 20:06
@Borda
Copy link
Author

Borda commented Apr 6, 2024

We have the separate because we run the tests on multiple platforms and multiple python versions, but we only want to run coverage reports on one platform and one python version. This is the standard pattern on most Scientific Python projects.

I see, but with Codecov, id does a fusion of all received reports for a particular commit, and with the newly added flags/tags, you can validate what lines are visited only for a specific configuration...

Anyway, just a suggestion, and feel free to close it :)

@Borda Borda marked this pull request as ready for review March 28, 2025 11:26
@Borda
Copy link
Author

Borda commented Mar 28, 2025

@jarrodmillman, mind have a look or feel free to close it... :)

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.60%. Comparing base (024e49f) to head (6c20235).

❗ There is a different number of reports uploaded between BASE (024e49f) and HEAD (6c20235). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (024e49f) HEAD (6c20235)
1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   96.00%   89.60%   -6.41%     
==========================================
  Files           5        5              
  Lines         250      250              
==========================================
- Hits          240      224      -16     
- Misses         10       26      +16     
Flag Coverage Δ
Linux 89.60% <ø> (?)
Windows 89.60% <ø> (?)
macOS 89.60% <ø> (?)
py3.10 89.60% <ø> (?)
py3.11 89.60% <ø> (?)
py3.12 89.60% <ø> (?)
py3.13 89.60% <ø> (?)
py3.9 89.60% <ø> (?)
pypypy-3.10 89.60% <ø> (?)
pypypy-3.9 89.60% <ø> (?)
unittests 89.60% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies
Copy link
Collaborator

This would really only be worth it if we had different jobs that covered different things. I don't see any coverage gaps that couldn't be handled by a couple more tests and mocking the environment, so I'm going to close this.

@effigies effigies closed this May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants