Skip to content

Add suppress_warning parameter to the load function #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Mar 16, 2025

I find this tedious to suppress using standard functionality.

My use case is a package foo.bar that consumers may import at any time that must lazily load foo._bar. This foo._bar module tests for the presence of a third party library but foo.bar can't just lazily load that library because it's functionality is not used all the time and we don't want to increase baseline memory for everyone.

Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.72%. Comparing base (5d2a084) to head (359774f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   95.72%   95.72%           
=======================================
  Files           5        5           
  Lines         234      234           
=======================================
  Hits          224      224           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefanv stefanv added the type: Enhancement New feature or request label Mar 18, 2025
@ofek
Copy link
Contributor Author

ofek commented Mar 19, 2025

Thanks for the review! Should this get merged, do you know when the next release might be?

@effigies
Copy link
Collaborator

I think we probably should release soonish, since there is a bugfix in.

LGTM as well.

@effigies effigies merged commit 513f429 into scientific-python:main Mar 19, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants