test: Update test cases to get full coverage #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__getattr__() is called on missing values. Actually existing values will be returned without hitting this method.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
============================================
+ Coverage 87.27% 100.00% +12.72%
============================================
Files 1 1
Lines 110 108 -2
Branches 20 19 -1
============================================
+ Hits 96 108 +12
+ Misses 7 0 -7
+ Partials 7 0 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to test the EAGER_IMPORT functionality, and figured we could cover these last few missing lines.
I did remove a guard in
DelayedImportErrorModule.__getattr__that coverage showed was never being entered. That method does not need asuper()call, since__class__,__frame_dataand__messagewill all be retrieved without entering that function, and I don't think__file__needs to get a normalAttributeErrorinstead ofModuleNotFoundError.