Skip to content

SymPy tests are failing #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Saransh-cpp opened this issue Apr 28, 2025 · 3 comments · Fixed by #581
Closed

SymPy tests are failing #579

Saransh-cpp opened this issue Apr 28, 2025 · 3 comments · Fixed by #581
Assignees
@Schefflera-Arboricola
Labels
good first issue Good for newcomers tests More or better tests are needed

Comments

@Saransh-cpp
Copy link
Member

The SymPy tests are failing in CI - https://github.com/scikit-hep/vector/actions/runs/14703378893
@Saransh-cpp Saransh-cpp added the tests More or better tests are needed label Apr 28, 2025
@Saransh-cpp Saransh-cpp self-assigned this Apr 28, 2025
@Schefflera-Arboricola
Copy link
Contributor

Could I please try resolving this?

Also, I was not able to reproduce these locally. But, maybe we can resolve these using sympy.simplify() or instead of checking if they are equal we can assert if their difference is 0? Please LMK if my thinking is in the right direction.

@Saransh-cpp
Copy link
Member Author

Sure, go ahead! Both the approaches sound good to me.

Merged
7 tasks
@Saransh-cpp Saransh-cpp added the good first issue Good for newcomers label May 8, 2025
@APN-Pucky APN-Pucky mentioned this issue May 8, 2025
Closed
4 tasks
@APN-Pucky
Copy link
Member

FYI, the tests pass with sympy-1.13.3, but seem to fail with 1.14.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Schefflera-Arboricola Schefflera-Arboricola

Labels
good first issue Good for newcomers tests More or better tests are needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixing sympy tests Schefflera-Arboricola/vector
3 participants
@APN-Pucky @Saransh-cpp @Schefflera-Arboricola