Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline cropping, filter and validate file types #78

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fuenfzehndreissig
Copy link

The following features has been added:

  • Inline cropping and scaling with canvas (in addition to inline processing)
  • Filter and validate file types to prevent upload of non image files

fuenfzehndreissig added 3 commits March 2, 2015 14:58
In order to handle only image file types, an image filter for the file input field has been added.

Unfortunately browsers handle this filter not reliably. Thus a validation also has been added in this update.
In addition to inline processing cropping and scaling with canvas on the client side has been added.
@sconsult
Copy link
Owner

sconsult commented Mar 6, 2015

Hi @fuenfzehndreissig

Very good additions, thank you for your effort. Filter and Refactoring are good to merge, i would like to ask one modification for the inlineCrop. Please add a dedicated option to enable inlineCrop.

Quality can in most of the cases only ensured if your using a high level image library such as imagemagick, thats why we have not added inlinecrop in the past, only the inline upload.

However i would merge the changes into the master if this option is added.

Cheers

Mat

@fuenfzehndreissig
Copy link
Author

Hi Mat,

sorry for my late response. I spended the last weeks on holiday.

Glad to here that my additions can be useful. I will add the dedicated
option to enable inlineCrop in the next days.

Best regards
Christian

Am 06.03.2015 um 21:02 schrieb Mat Steinlin:

Hi @fuenfzehndreissig https://github.com/fuenfzehndreissig

Very good additions, thank you for your effort. Filter and Refactoring
are good to merge, i would like to ask one modification for the
inlineCrop. Please add a dedicated option to enable inlineCrop.

Quality can in most of the cases only ensured if your using a high
level image library such as imagemagick, thats why we have not added
inlinecrop in the past, only the inline upload.

However i would merge the changes into the master if this option is added.

Cheers

Mat


Reply to this email directly or view it on GitHub
#78 (comment).

@felipeduardo
Copy link

@fuenfzehndreissig @sconsult this PR is ok?

@bindesh
Copy link

bindesh commented Oct 1, 2015

Hi @fuenfzehndreissig

when i use inlineprocess for croppic it gives me an error "Image type is not supported" for only large images i have made changes into php.ini file but still getting this error
Croppic is working nice in it's normal process but i need to use the process inline functionality in this ..
also this image is supported in normal process but in process inline it is creating a big problem.
can you help me out of this problem as soon as possible?

here i attach my error screen shot

please reply me it's very urgent

untitled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants