Use async singleton router for MemoryRouterProvider #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d2e8fff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Merging this PR would also fix issue #111 . |
|
@scottrippey Any chance of getting this merged? It's currently blocking a crucial update for us. |
scottrippey
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the
next-router-mock/asyncprovider and had a bunch of issues with the Provider, as it appeared all manipulations of the router get ignored by our components.Looking into the code, I discovered why: The
<MemoryRouterProvider />ignores theasyncprop unless anurlis given. However, when anurlis given, a new router is created.This should return the async singleton when requested - however, I could not test if it works for our application as I couldn't figure out how to include the package without it being published.