-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for search prop #120
add support for search prop #120
Conversation
🦋 Changeset detectedLatest commit: 5afd47b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I noticed this PR #82 where node dependencies were eliminated. I just pushed some new changes that should address this. Didn't go with straight With query-string this behaviour is allowed: import queryString from 'query-string';
queryString.parse('foo=1&foo=2&foo=3');
//=> {foo: ['1', '2', '3']} Happy to read your thoughts. Thank you! EDIT: ah pushed commit is messed up because it still uses node |
ended up removing external dependency and used parsedUrl directly, feels kind of hacky but seems to do the trick. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the tests, great job! Thanks for reusing the existing parsing logic, rather than adding dependencies.
Some tiny comments below:
This PR adds support for search prop which while using the library we noticed it was yet not supported
Thanks a lot for this amazing package!