Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish only dist directory #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

andriyor
Copy link

@andriyor andriyor commented May 1, 2024

i use noUnusedParameters: true and see such error during type checking

image

Copy link

changeset-bot bot commented May 1, 2024

⚠️ No Changeset found

Latest commit: ac51efb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@SalahAdDin
Copy link

@scottrippey any review here?

Copy link
Owner

@scottrippey scottrippey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually a fan of repos that publish their src folder, because I love jumping into the original implementation.

I think a better solution is to reconfigure tsc to ignore the node_modules folder for type checking; this should speed it up and will avoid issues with other dependencies too.

Comment on lines -8 to -10
"async",
"dynamic-routes",
"MemoryRouterProvider",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are actually required, as they provide entry points for these features

@scottrippey scottrippey added invalid This doesn't seem right wontfix This will not be worked on typescript TypeScript problems or improvements and removed invalid This doesn't seem right labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript TypeScript problems or improvements wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants