Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counts don't load when there are html comments on page #4

Open
actual-saurabh opened this issue Jul 30, 2013 · 2 comments
Open

Counts don't load when there are html comments on page #4

actual-saurabh opened this issue Jul 30, 2013 · 2 comments

Comments

@actual-saurabh
Copy link

I get this error on line 300 of coin.js

Uncaught Error: HierarchyRequestError: DOM Exception 3

when I check on the console: document.lastChild.firstChild

It logs an html comment. and hence the counts never load. Could you filter that for html comments
@actual-saurabh
Copy link
Author

If you check the nodeType to ensure if it is indeed an element and not an html comment. Better still, is there any reason why you can't select the <head> node directly instead of going the document.lastChild.firstChild way?

@actual-saurabh
Copy link
Author

You could use document.getElementsByTagName('head') instead of that.

@actual-saurabh actual-saurabh mentioned this issue Aug 2, 2013
Open
mitar pushed a commit to wlanslovenija/coinwidget.com that referenced this issue Nov 16, 2013
Update coin.js
ce454d6 
Changed head node locating code to take care of scottycc#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@actual-saurabh