Skip to content

added microphone examples for node and browser #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added microphone examples for node and browser #1

wants to merge 2 commits into from

Conversation

mreinstein
Copy link

shows minimal code to take microphone input and render it with waveform :)

@mreinstein
Copy link
Author

@dfcreative any thoughts on these?

@dy
Copy link
Member

dy commented Feb 6, 2017

@mreinstein thank you for the contribution, I will try to include these examples with updated renderer (it takes gl-waveform, which takes signal-tree to be done).

package.json Outdated
@@ -30,7 +31,9 @@
"devDependencies": {
"audio-generator": "^1.0.5",
"audio-speaker": "^1.1.2",
"watchify": "^3.6.0"
"mic": "^2.1.1",
"watchify": "^3.6.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotta switch to budo, no need in watchify anymore

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could use budo, but it's a lot more complex than watchify. And the example works by opening the test.html directly from a folder. No need to have a server to run it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfcreative any thoughts on this?

Copy link
Member

@dy dy Mar 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mreinstein why budo is complex? I mean we should not add it to dependency of course, but budo test for me is pretty simple 😄
Also there is CORS-limitations on running files/mic from locally opened file.

Copy link
Author

@mreinstein mreinstein Mar 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfcreative

why budo is complex?

watchify is dead simple. It just watches the file for changes and runs browserify on it. budo has a bit more of the kitchen sink, (css watching, plugin architecture, etc.)

but budo test for me is pretty simple

It's definitely simple to run, but has a lot of stuff going on under the hood. I guess it's just personal tastes. I like minimal things (even dev tools) that have less features but are smaller and specific.

That said, if you really like budo I don't want to force anyone into my preferences. :) I'm happy to update this to budo if you really want it. 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is CORS-limitations on running files/mic from locally opened file

in Chrome at least, I'm able to click the examples/microphone-browser/index.html file, click "allow" from the "use microphone" popup dialog, and see the waveform render.

@mreinstein
Copy link
Author

mreinstein commented Apr 17, 2017

@dfcreative I see what you mean about budo. Definitely gets rid of some of the watchify/serving boilerplate. I've updated the PR to use it, and removed the old plumbing. Is the PR good to go?

@mreinstein
Copy link
Author

@dfcreative not to be a pest but any chance of getting this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants