Skip to content

Commit 201d6c3

Browse files
committed
fix: Work around limit in lambda policy size
Currently failing with ``` │ Error: adding Lambda Permission (arn:aws:lambda:us-east-2:591234544403:function:model-inference-development-datadog-forwarder/_aws_sagemaker_Endpoints_recs-ranker-rn-scribd-has-read-after-AllowExecutionFromCloudWatchLogs): PolicyLengthExceededException: The final policy size (20782) is bigger than the limit (20480). │ { │ RespMetadata: { │ StatusCode: 400, │ RequestID: "e220c7fb-c4c9-4b93-9f15-beba592a3afc" │ }, │ Message_: "The final policy size (20782) is bigger than the limit (20480).", │ Type: "User" │ } │ │ with module.datadog[0].aws_lambda_permission.allow_cloudwatch_logs_to_call_dd_lambda_handler["/aws/sagemaker/Endpoints/recs-ranker-rn-scribd-has-read-after"], │ on .terraform/modules/datadog/logs_monitoring_cloudwatch_log.tf line 10, in resource "aws_lambda_permission" "allow_cloudwatch_logs_to_call_dd_lambda_handler": │ 10: resource "aws_lambda_permission" "allow_cloudwatch_logs_to_call_dd_lambda_handler" { } ``` Current size of lambda policy: ``` $ aws lambda get-policy --function-name model-inference-development-datadog-forwarder | jq -r '.Policy' | wc 1 1 20090 ``` Now we can pass array like `log_group_prefixes = ["/aws/sagemaker/Endpoints/", "/aws/sagemaker/TransformJobs"]` to force small size of the policy if necessary Changed to the module are backward-compatible
1 parent 3678529 commit 201d6c3

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

locals.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@ locals {
55
namespace = var.namespace
66
terraform = "true"
77
}
8+
log_groups_to_use = length(var.log_group_prefixes) > 0 ? var.log_group_prefixes : var.cloudwatch_log_groups
89
}

logs_monitoring_cloudwatch_log.tf

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,12 @@ resource "aws_cloudwatch_log_subscription_filter" "test_lambdafunction_logfilter
88
}
99

1010
resource "aws_lambda_permission" "allow_cloudwatch_logs_to_call_dd_lambda_handler" {
11-
for_each = { for lg in var.cloudwatch_log_groups : lg => lg }
11+
for_each = { for lg in local.log_groups_to_use : lg => lg }
1212
statement_id = "${substr(replace(each.value, "/", "_"), 0, 67)}-AllowExecutionFromCloudWatchLogs"
1313
action = "lambda:InvokeFunction"
1414
function_name = aws_cloudformation_stack.datadog-forwarder.outputs.DatadogForwarderArn
1515
principal = "logs.${var.aws_region}.amazonaws.com"
16-
source_arn = "arn:aws:logs:${var.aws_region}:${var.aws_account_id}:log-group:${each.value}:*"
16+
source_arn = (length(var.log_group_prefixes) > 0 ?
17+
"arn:aws:logs:${var.aws_region}:${var.aws_account_id}:log-group:${each.value}*" :
18+
"arn:aws:logs:${var.aws_region}:${var.aws_account_id}:log-group:${each.value}:*")
1719
}

vars.tf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,11 @@ variable "cloudwatch_log_groups" {
3737
type = list(string)
3838
default = []
3939
}
40+
variable "log_group_prefixes" {
41+
description = "List of CloudWatch Log Group prefixes to create lambda permissions"
42+
type = list(string)
43+
default = []
44+
}
4045
variable "enable_datadog_aws_integration" {
4146
description = "Use datadog provider to give datadog aws account access to our resources"
4247
type = bool

0 commit comments

Comments
 (0)