Skip to content

Fixes resolVI. #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2025
Merged

Fixes resolVI. #3308

merged 4 commits into from
May 8, 2025

Conversation

canergen
Copy link
Member

@canergen canergen commented May 8, 2025

Several bug fixes for reported issues.

#3283
#3208
#3289
#3267

@canergen canergen requested a review from ori-kron-wis May 8, 2025 12:13
Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.40%. Comparing base (17da5f7) to head (20ab137).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/scvi/external/resolvi/_model.py 66.66% 3 Missing ⚠️
src/scvi/external/resolvi/_utils.py 60.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (17da5f7) and HEAD (20ab137). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (17da5f7) HEAD (20ab137)
12 3
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3308      +/-   ##
==========================================
- Coverage   86.63%   80.40%   -6.23%     
==========================================
  Files         193      193              
  Lines       17130    17133       +3     
==========================================
- Hits        14840    13776    -1064     
- Misses       2290     3357    +1067     
Files with missing lines Coverage Δ
src/scvi/external/resolvi/_module.py 95.51% <ø> (+2.41%) ⬆️
src/scvi/external/resolvi/_utils.py 86.39% <60.00%> (+22.48%) ⬆️
src/scvi/external/resolvi/_model.py 91.66% <66.66%> (-1.07%) ⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis
Copy link
Collaborator

maybe better to add a changlog

@canergen canergen merged commit b3648e0 into main May 8, 2025
15 of 16 checks passed
@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.3.x on-merge: backport to 1.3.x label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-merge: backport to 1.3.x on-merge: backport to 1.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants