refactor(treewide): decouple native backup and restore support

It turns out that the support for native backup and restore API
will be a part of different Scylla releases.

Author: Michal-Leszczynski

pkg/scyllaclient/client_agent.go

@@ -269,8 +269,8 @@ func (ni *NodeInfo) SupportsSafeDescribeSchemaWithInternals() (SafeDescribeMetho
 	return "", nil
 }
 
-// SupportsScyllaBackupRestoreAPI returns whether node exposes /storage_service/<backup|restore> API.
-func (ni *NodeInfo) SupportsScyllaBackupRestoreAPI() (bool, error) {
+// SupportsNativeBackupAPI returns whether node exposes /storage_service/backup API.
+func (ni *NodeInfo) SupportsNativeBackupAPI() (bool, error) {
 	// Detect master builds
 	if scyllaversion.MasterVersion(ni.ScyllaVersion) {
 		return true, nil
@@ -279,9 +279,9 @@ func (ni *NodeInfo) SupportsScyllaBackupRestoreAPI() (bool, error) {
 	return scyllaversion.CheckConstraint(ni.ScyllaVersion, ">= 2025.2")
 }
 
-// ScyllaBackupRestoreEndpoint returns endpoint that should be used when calling /storage_service/<backup|restore> API.
+// ScyllaObjectStorageEndpoint returns endpoint that should be used when calling /storage_service/<backup|restore> API.
 // It also validates that agent's and Scylla's configurations match.
-func (ni *NodeInfo) ScyllaBackupRestoreEndpoint(provider backupspec.Provider) (string, error) {
+func (ni *NodeInfo) ScyllaObjectStorageEndpoint(provider backupspec.Provider) (string, error) {
 	if provider != backupspec.S3 {
 		return "", errors.Errorf("unsupported provider %s for native Scylla backup and restore", provider)
 	}

pkg/service/backup/service_backup_integration_test.go

@@ -2592,7 +2592,7 @@ func TestBackupAPIHintIntegration(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	support, err := ni.SupportsScyllaBackupRestoreAPI()
+	support, err := ni.SupportsNativeBackupAPI()
 	if err != nil {
 		t.Fatal(err)
 	}

pkg/service/backup/worker_scylla_upload.go

@@ -14,14 +14,14 @@ import (
 
 // hostNativeBackupSupport validates that native backup API can be used for given host.
 func hostNativeBackupSupport(ni *scyllaclient.NodeInfo, loc backupspec.Location) error {
-	ok, err := ni.SupportsScyllaBackupRestoreAPI()
+	ok, err := ni.SupportsNativeBackupAPI()
 	if err != nil {
 		return errors.Wrap(err, "check native backup api support")
 	}
 	if !ok {
 		return errors.New("native backup api is not supported")
 	}
-	_, err = ni.ScyllaBackupRestoreEndpoint(loc.Provider)
+	_, err = ni.ScyllaObjectStorageEndpoint(loc.Provider)
 	if err != nil {
 		return errors.Wrap(err, "check scylla object storage endpoint")
 	}
@@ -65,7 +65,7 @@ func (w *worker) nativeBackup(ctx context.Context, hi hostInfo, d snapshotDir) e
 		"table", d.Table)
 	if d.Progress.ScyllaTaskID == "" || !w.scyllaCanAttachToTask(ctx, hi.IP, d.Progress.ScyllaTaskID) {
 		prefix := w.remoteSSTableDir(hi, d)
-		endpoint, err := hi.NodeConfig.ScyllaBackupRestoreEndpoint(hi.Location.Provider)
+		endpoint, err := hi.NodeConfig.ScyllaObjectStorageEndpoint(hi.Location.Provider)
 		if err != nil {
 			return errors.Wrap(err, "get Scylla object storage endpoint")
 		}

pkg/service/restore/restore_integration_test.go

@@ -505,7 +505,7 @@ func TestRestoreTablesPreparationIntegration(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	nativeAPISupport, err := ni.SupportsScyllaBackupRestoreAPI()
+	nativeBackupSupport, err := ni.SupportsNativeBackupAPI()
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -633,7 +633,7 @@ func TestRestoreTablesPreparationIntegration(t *testing.T) {
 	})
 
 	Print("Validate state after backup")
-	if nativeAPISupport {
+	if nativeBackupSupport && !IsIPV6Network() {
 		validateState(h.srcCluster, "repair", true, 10, 99, pinnedCPU)
 	} else {
 		validateState(h.srcCluster, "repair", true, 3, 88, pinnedCPU)