-
Notifications
You must be signed in to change notification settings - Fork 43
Remove most of the iputils from tests #4342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 3, 2025
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 7, 2025
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 7, 2025
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 8, 2025
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 9, 2025
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 9, 2025
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 9, 2025
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 9, 2025
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 9, 2025
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 10, 2025
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 10, 2025
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 10, 2025
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 17, 2025
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 22, 2025
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 22, 2025
…d repair.Target This commit tries to improve IPV6 handling by storing addr as netip.Addr instead of string. It does so mainly for scyllaclient.Ring and repair.Target and it adjusts all other required places in the code. Ref #4342
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 23, 2025
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 24, 2025
Michal-Leszczynski
added a commit
that referenced
this issue
Apr 29, 2025
Michal-Leszczynski
added a commit
that referenced
this issue
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
So basically, SM handles IPV6 poorly, as in most places it stores IP addresses in string format and compares them as strings as well.
Since IPV6 does not have a unique string representation, it creates issues.
And what are we doing when a test fails beacuse of mismatch in IPV6 string representation?
We alter the test to use required representation instead of fixing SM implementation...
Functions like:
Needs to be removed from our tests so that we are not hiding problems with IPV6 handling.
Obviously, SM implementation needs to be updated to handle those cases correctly.
The text was updated successfully, but these errors were encountered: